Skip to content

feat: support namedtuple for struct types #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025

Conversation

lemorage
Copy link
Contributor

This PR tries to resolve #437.

NamedTuples support is added, so now struct types can be defined either by a dataclass or a namedtuple. A bunch of unit tests added for verifying the functionality and the docs is updated correpondingly.

Copy link
Member

@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! Really appreciate the speed and code quality!

@badmonster0 badmonster0 merged commit aa9ab60 into cocoindex-io:main May 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support NamedTuple in addition to dataclass in Python SDK
2 participants